Skip to content

Conversation

@rouzwelt
Copy link
Collaborator

@rouzwelt rouzwelt commented Feb 5, 2025

Motivation

resolves #137

Solution

there is memory leak when using compose which comes from magic-string lib which is a sourcemapping lib.
That lib seems to be not very active, we have opened PR there with the fix, but until that gets picked by maintainers, we need to use that solution as a submod dep.
h-a-n-a/magic-string-rs#27

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@rouzwelt rouzwelt added the bug Something isn't working label Feb 5, 2025
@rouzwelt rouzwelt self-assigned this Feb 5, 2025
@rouzwelt rouzwelt requested a review from hardyjosh February 5, 2025 18:03
@rouzwelt rouzwelt merged commit 4f623a4 into main Feb 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dotrain compose has memory leak issue

3 participants